-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Enable adding NodeBalancer to Linode Firewall #539
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 63.63% 63.78% +0.15%
==========================================
Files 79 79
Lines 5486 5575 +89
==========================================
+ Hits 3491 3556 +65
- Misses 1719 1738 +19
- Partials 276 281 +5 ☔ View full report in Codecov by Sentry. |
…LinodeCluster resource
…y created which is managed outside of the CAPL ecosystem by passing Firewall ID
…FirewallID. Update the other lb flavor (bgp, dns, and dual-stack) to not add firewall for nb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: