[Feat] Enable adding NodeBalancer to Linode Firewall #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 63.63% 63.78% +0.15%
==========================================
Files 79 79
Lines 5486 5575 +89
==========================================
+ Hits 3491 3556 +65
- Misses 1719 1738 +19
- Partials 276 281 +5 ☔ View full report in Codecov by Sentry. |
added 5 commits
October 14, 2024 18:20
…LinodeCluster resource
…y created which is managed outside of the CAPL ecosystem by passing Firewall ID
eljohnson92
reviewed
Oct 15, 2024
eljohnson92
reviewed
Oct 15, 2024
added 2 commits
October 15, 2024 12:14
…FirewallID. Update the other lb flavor (bgp, dns, and dual-stack) to not add firewall for nb
rahulait
reviewed
Oct 15, 2024
rahulait
reviewed
Oct 15, 2024
rahulait
reviewed
Oct 16, 2024
rahulait
reviewed
Oct 16, 2024
rahulait
reviewed
Oct 17, 2024
rahulait
previously approved these changes
Oct 21, 2024
eljohnson92
previously approved these changes
Oct 21, 2024
eljohnson92
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: